Shaka 4.8.5-r1.2 EventStream issue

[Douglas_Loftus]

---

shaka 4.8.5-r1.2 EventStream issue

---

1. Summary

In the course of testing shaka 4.8.5-r1.2 with a DASH stream featuring in-manifest EventStream metadata, we observed that shaka is not emitting any TimelineRegionEnter events for this manifest. However, using shaka 4.6.18-r2.15, TimelineRegionEnter events are observed and convey the expected metadata.

This metadata is critical to ad verification and monetization.

This behavior has been observed by 3 engineers with independent device setups.

Logs below for both shaka versions reflect capture (or absence) of TimelineRegionEnter events for a portion of the pre-roll ad break.

App Name: pplus
Bug Severity
Select one that applies

• Impacts ad monetization

5. Logs or crash report

These are filtered logs; no errors or other revealing statements were observed in 4.8.5 logs in the vicinity of the lines shown below

Q: your media/content url

To be shared

Logs

Using 4.6.18, we see the expected set of log statements for the "first quartile" and "midpoint" of the ad lifecycle:

Sep 30 20:38:04.110983 ||===|| AD EVENT adfirstquartile @7.51
Sep 30 20:38:04.306422 ||===|| SHAKA ADAPTER onTimelineRegionEnter got metadata cuepoint with PTS 7.507, text = google_0316984025609478659
Sep 30 20:38:04.306698 ||===|| DAI Ad Adapter handleTimedMetadata google_0316984025609478659 / PTS: 7.507, 7.51
Sep 30 20:38:04.306835 ||===|| DAI API StreamMgr sending verification beacon with id google_0316984025609478659
Sep 30 20:38:04.310665 ||===|| METADATA_CUEPOINT @ @7.51; PTS: 7.507 / google_0316984025609478659

Sep 30 20:38:11.419888 ||===|| AD EVENT admidpoint @14.773
Sep 30 20:38:11.563430 ||===|| SHAKA ADAPTER onTimelineRegionEnter got metadata cuepoint with PTS 14.765, text = google_0436054351108653926
Sep 30 20:38:11.563725 ||===|| DAI Ad Adapter handleTimedMetadata google_0436054351108653926 / PTS: 14.765, 14.773
Sep 30 20:38:11.563904 ||===|| DAI API StreamMgr sending verification beacon with id google_0436054351108653926
Sep 30 20:38:11.565177 ||===|| METADATA_CUEPOINT @ @14.773; PTS: 14.765 / google_0436054351108653926

Using 4.8.5:
 
Sep 30 20:10:42.930609  ||===|| AD EVENT adfirstquartile @7.509
Sep 30 20:10:50.235092  ||===|| AD EVENT admidpoint @14.773

---

[will.harris]

We noticed the 0030 patch in Shaka 4.8.5-r.1.2 might be a relevant place to start looking at this issue. It is applied in the parseEventStream_ method of dash_parser.js.

0030-fix-dash-EventStream-parsing.patch.txt (1.5 KB)

Comment from patch:

dash EventStream parsing is stuck while converting event node
to dom element, this is due to missing dom implementation,
add placeholder element for event node skipping actual conversion
as the attribute is already depcrecated.

As noted in the original post, this issue is not present in v4.6.18 of Shaka. One major change from 4.6 to 4.8 was the removal of DOMParser and implementation of TXML. That might be a relevant change to look at as well.

feat!: Remove DOM Parser

[satish_amazon]

@Douglas_Loftus

Based on our slack chat, I will resolve this post with a resolution to use eventNode instead of eventElement.